[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium |
Date: |
Mon, 9 Feb 2015 12:11:28 -0500 |
And a helper function for that which directly takes a pointer to the BDS
to be inserted instead of its node-name (which will be used for
implementing 'change' using blockdev-insert-medium).
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
blockdev.c | 43 +++++++++++++++++++++++++++++++++++++++++++
qapi/block-core.json | 17 +++++++++++++++++
qmp-commands.hx | 37 +++++++++++++++++++++++++++++++++++++
3 files changed, 97 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 2544c6f..819a3c1 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2070,6 +2070,49 @@ void qmp_blockdev_remove_medium(const char *device,
Error **errp)
}
}
+static void qmp_blockdev_insert_anon_medium(const char *device,
+ BlockDriverState *bs, Error **errp)
+{
+ BlockBackend *blk;
+
+ blk = blk_by_name(device);
+ if (!blk) {
+ error_set(errp, QERR_DEVICE_NOT_FOUND, device);
+ return;
+ }
+
+ if (!blk_dev_has_removable_media(blk)) {
+ error_setg(errp, "Device '%s' is not removable", device);
+ return;
+ }
+
+ if (!blk_dev_is_tray_open(blk)) {
+ error_setg(errp, "Tray of device '%s' is not open", device);
+ return;
+ }
+
+ if (blk_bs(blk)) {
+ error_setg(errp, "There already is a medium in device '%s'", device);
+ return;
+ }
+
+ blk_insert_bs(blk, bs);
+}
+
+void qmp_blockdev_insert_medium(const char *device, const char *node_name,
+ Error **errp)
+{
+ BlockDriverState *bs;
+
+ bs = bdrv_find_node(node_name);
+ if (!bs) {
+ error_setg(errp, "Node '%s' not found", node_name);
+ return;
+ }
+
+ qmp_blockdev_insert_anon_medium(device, bs, errp);
+}
+
/* throttling disk I/O limits */
void qmp_block_set_io_throttle(const char *device, int64_t bps, int64_t bps_rd,
int64_t bps_wr,
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 7f0f21c..d5de622 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1784,6 +1784,23 @@
{ 'command': 'blockdev-remove-medium',
'data': { 'device': 'str' } }
+##
+# @blockdev-insert-medium:
+#
+# Inserts a medium (a block driver state tree) into a block device. That block
+# device's tray must currently be open and there must be no medium inserted
+# already.
+#
+# @device: block device name
+#
+# @node-name: name of a node in the block driver state graph
+#
+# Since: 2.3
+##
+{ 'command': 'blockdev-insert-medium',
+ 'data': { 'device': 'str',
+ 'node-name': 'str'} }
+
##
# @BlockErrorAction
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 1bd39b7..70b05e2 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -3774,6 +3774,43 @@ Example:
EQMP
{
+ .name = "blockdev-insert-medium",
+ .args_type = "device:s,node-name:s",
+ .mhandler.cmd_new = qmp_marshal_input_blockdev_insert_medium,
+ },
+
+SQMP
+blockdev-insert-medium
+----------------------
+
+Inserts a medium (a block driver state tree) into a block device. That block
+device's tray must currently be open and there must be no medium inserted
+already.
+
+Arguments:
+
+- "device": block device name (json-string)
+- "node-name": root node of the BDS tree to insert into the block device
+
+Example:
+
+-> { "execute": "blockdev-add",
+ "arguments": { "options": { "node-name": "node0",
+ "driver": "raw",
+ "file": { "driver": "file",
+ "filename": "fedora.iso" } } } }
+
+<- { "return": {} }
+
+-> { "execute": "blockdev-insert-medium",
+ "arguments": { "device": "ide1-cd0",
+ "node-name": "node0" } }
+
+<- { "return": {} }
+
+EQMP
+
+ {
.name = "query-named-block-nodes",
.args_type = "",
.mhandler.cmd_new = qmp_marshal_input_query_named_block_nodes,
--
2.1.0
- [Qemu-devel] [PATCH v2 34/37] blockdev: read-only-mode for blockdev-change-medium, (continued)
- [Qemu-devel] [PATCH v2 34/37] blockdev: read-only-mode for blockdev-change-medium, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 27/37] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 33/37] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 36/37] iotests: More options for VM.add_drive(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 31/37] block: Inquire tray state before tray-moved events, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 32/37] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 35/37] hmp: Add read-only-mode option to change command, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 37/37] iotests: Add test for change-related QMP commands, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 23/37] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium,
Max Reitz <=
- [Qemu-devel] [PATCH v2 30/37] blockdev: Implement change with basic operations, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 29/37] blockdev: Implement eject with basic operations, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 20/37] block: Prepare for NULL BDS, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 26/37] blockdev: Add blockdev-close-tray, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 25/37] blockdev: Add blockdev-open-tray, Max Reitz, 2015/02/09