[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 11/19] libqos/ahci: Add ide cmd properties
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v3 11/19] libqos/ahci: Add ide cmd properties |
Date: |
Thu, 5 Feb 2015 12:41:22 -0500 |
Add a structure that defines some properties of various IDE commands.
These will be used to simplify the interface to the libqos AHCI calls,
lessening the redundancy of specifying and respecifying properties of
commands to various helper functions.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
tests/libqos/ahci.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index ac32849..fa40ee3 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -34,6 +34,45 @@
#include "hw/pci/pci_ids.h"
#include "hw/pci/pci_regs.h"
+typedef struct AHCICommandProp {
+ uint8_t cmd; /* Command Code */
+ bool data; /* Data transfer command? */
+ bool pio;
+ bool dma;
+ bool lba28;
+ bool lba48;
+ bool read;
+ bool write;
+ bool atapi;
+ bool ncq;
+ uint64_t size; /* Static transfer size, for commands like IDENTIFY.
*/
+ uint32_t interrupts; /* Expected interrupts for this command. */
+} AHCICommandProp;
+
+AHCICommandProp ahci_command_properties[] = {
+ { .cmd = CMD_READ_PIO, .data = true, .pio = true,
+ .lba28 = true, .read = true },
+ { .cmd = CMD_WRITE_PIO, .data = true, .pio = true,
+ .lba28 = true, .write = true },
+ { .cmd = CMD_READ_PIO_EXT, .data = true, .pio = true,
+ .lba48 = true, .read = true },
+ { .cmd = CMD_WRITE_PIO_EXT, .data = true, .pio = true,
+ .lba48 = true, .write = true },
+ { .cmd = CMD_READ_DMA, .data = true, .dma = true,
+ .lba28 = true, .read = true },
+ { .cmd = CMD_WRITE_DMA, .data = true, .dma = true,
+ .lba28 = true, .write = true },
+ { .cmd = CMD_READ_DMA_EXT, .data = true, .dma = true,
+ .lba48 = true, .read = true },
+ { .cmd = CMD_WRITE_DMA_EXT, .data = true, .dma = true,
+ .lba48 = true, .write = true },
+ { .cmd = CMD_IDENTIFY, .data = true, .pio = true,
+ .size = 512, .read = true },
+ { .cmd = CMD_READ_MAX, .lba28 = true },
+ { .cmd = CMD_READ_MAX_EXT, .lba48 = true },
+ { .cmd = CMD_FLUSH_CACHE, .data = false }
+};
+
/**
* Allocate space in the guest using information in the AHCIQState object.
*/
--
1.9.3
- [Qemu-devel] [PATCH v3 02/19] libqos/ahci: Add ahci_port_clear helper, (continued)
- [Qemu-devel] [PATCH v3 02/19] libqos/ahci: Add ahci_port_clear helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 06/19] libqos/ahci: Add ahci_port_check_interrupts helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 05/19] libqos/ahci: Add ahci_port_check_error helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 07/19] libqos/ahci: Add port_check_nonbusy helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 14/19] libqos/ahci: add ahci command size setters, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 13/19] libqos/ahci: add ahci command verify, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 08/19] libqos/ahci: Add cmd response sanity check helpers, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 17/19] libqos/ahci: Add ahci_clean_mem, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 16/19] libqos/ahci: add ahci_io, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 09/19] qtest/ahci: Demagic ahci tests., John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 11/19] libqos/ahci: Add ide cmd properties,
John Snow <=
- [Qemu-devel] [PATCH v3 18/19] qtest/ahci: Assert sector size in identify test, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 12/19] libqos/ahci: add ahci command functions, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 10/19] qtest/ahci: add ahci_write_fis, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 15/19] libqos/ahci: Add ahci_guest_io, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 19/19] qtest/ahci: Adding simple dma read-write test, John Snow, 2015/02/05
- Re: [Qemu-devel] [PATCH v3 00/19] qtest/ahci: add dma test, Stefan Hajnoczi, 2015/02/12