[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 07/19] libqos/ahci: Add port_check_nonbusy helper
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v3 07/19] libqos/ahci: Add port_check_nonbusy helper |
Date: |
Thu, 5 Feb 2015 12:41:18 -0500 |
A simple helper that asserts a given port is not busy processing any
commands via the TFD, Command Issue and SACT registers.
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
---
tests/ahci-test.c | 1 +
tests/libqos/ahci.c | 18 ++++++++++++++++++
tests/libqos/ahci.h | 1 +
3 files changed, 20 insertions(+)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 32b6be3..4cc7e21 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -751,6 +751,7 @@ static void ahci_test_identify(AHCIQState *ahci)
ahci_port_check_error(ahci, i);
/* BUG: we expect AHCI_PX_IS_DPS to be set. */
ahci_port_check_interrupts(ahci, i, AHCI_PX_IS_DHRS | AHCI_PX_IS_PSS);
+ ahci_port_check_nonbusy(ahci, i, cx);
/* Investigate the CMD, assert that we read 512 bytes */
ahci_get_command_header(ahci, i, cx, &cmd);
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 97dcc99..db3055f 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -347,6 +347,24 @@ void ahci_port_check_interrupts(AHCIQState *ahci, uint8_t
port,
g_assert_cmphex(ahci_px_rreg(ahci, port, AHCI_PX_IS), ==, 0);
}
+void ahci_port_check_nonbusy(AHCIQState *ahci, uint8_t port, uint8_t slot)
+{
+ uint32_t reg;
+
+ /* Assert that the command slot is no longer busy (NCQ) */
+ reg = ahci_px_rreg(ahci, port, AHCI_PX_SACT);
+ ASSERT_BIT_CLEAR(reg, (1 << slot));
+
+ /* Non-NCQ */
+ reg = ahci_px_rreg(ahci, port, AHCI_PX_CI);
+ ASSERT_BIT_CLEAR(reg, (1 << slot));
+
+ /* And assert that we are generally not busy. */
+ reg = ahci_px_rreg(ahci, port, AHCI_PX_TFD);
+ ASSERT_BIT_CLEAR(reg, AHCI_PX_TFD_STS_BSY);
+ ASSERT_BIT_CLEAR(reg, AHCI_PX_TFD_STS_DRQ);
+}
+
/* Get the command in #slot of port #port. */
void ahci_get_command_header(AHCIQState *ahci, uint8_t port,
uint8_t slot, AHCICommandHeader *cmd)
diff --git a/tests/libqos/ahci.h b/tests/libqos/ahci.h
index a2ffa70..eaad076 100644
--- a/tests/libqos/ahci.h
+++ b/tests/libqos/ahci.h
@@ -436,6 +436,7 @@ void ahci_port_clear(AHCIQState *ahci, uint8_t port);
void ahci_port_check_error(AHCIQState *ahci, uint8_t port);
void ahci_port_check_interrupts(AHCIQState *ahci, uint8_t port,
uint32_t intr_mask);
+void ahci_port_check_nonbusy(AHCIQState *ahci, uint8_t port, uint8_t slot);
void ahci_get_command_header(AHCIQState *ahci, uint8_t port,
uint8_t slot, AHCICommandHeader *cmd);
void ahci_set_command_header(AHCIQState *ahci, uint8_t port,
--
1.9.3
- [Qemu-devel] [PATCH v3 00/19] qtest/ahci: add dma test, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 03/19] qtest/ahci: rename 'Command' to 'CommandHeader', John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 01/19] libqos/ahci: Add ahci_port_select helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 04/19] libqos/ahci: Add command header helpers, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 02/19] libqos/ahci: Add ahci_port_clear helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 06/19] libqos/ahci: Add ahci_port_check_interrupts helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 05/19] libqos/ahci: Add ahci_port_check_error helper, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 07/19] libqos/ahci: Add port_check_nonbusy helper,
John Snow <=
- [Qemu-devel] [PATCH v3 14/19] libqos/ahci: add ahci command size setters, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 13/19] libqos/ahci: add ahci command verify, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 08/19] libqos/ahci: Add cmd response sanity check helpers, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 17/19] libqos/ahci: Add ahci_clean_mem, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 16/19] libqos/ahci: add ahci_io, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 09/19] qtest/ahci: Demagic ahci tests., John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 11/19] libqos/ahci: Add ide cmd properties, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 18/19] qtest/ahci: Assert sector size in identify test, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 12/19] libqos/ahci: add ahci command functions, John Snow, 2015/02/05
- [Qemu-devel] [PATCH v3 10/19] qtest/ahci: add ahci_write_fis, John Snow, 2015/02/05