[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KV
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64 |
|
Date: |
Wed, 21 Jan 2015 10:56:14 +0000 |
On 21 January 2015 at 10:54, Alex Bennée <address@hidden> wrote:
>
> Greg Bellows <address@hidden> writes:
>
>> On Tue, Jan 20, 2015 at 10:57 AM, Alex Bennée <address@hidden> wrote:
>>> I know why we do this (especially given where my attempt ended up) but
>>> perhaps we could at list have a single state aware accessor so we don't
>>> end up duplicating this test all over the place?
>>
>> I'd happily add an accessor function, but I only found 1 other
>> location that does this conditional so I'm not sure it is warranted.
>
> The migration/serialisation code? Today one other, tomorrow just one more?
Meh. I suggested to Greg that just inlining this at point of use
was the simplest approach. Maybe one day we'll clean this stuff
up but yet another accessor function doesn't seem too great either.
-- PMM
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, (continued)
[Qemu-devel] [PATCH 2/5] target-arm: Add feature parsing to virt, Greg Bellows, 2015/01/19
[Qemu-devel] [PATCH 3/5] target-arm: Add 32/64-bit register sync, Greg Bellows, 2015/01/19
[Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64, Greg Bellows, 2015/01/19
[Qemu-devel] [PATCH 5/5] target-arm: Adjust kernel load address for Image, Greg Bellows, 2015/01/19
Re: [Qemu-devel] [PATCH 0/5] target-arm: ARM64: Adding EL1 AARCH32 guest support, Sergey Fedorov, 2015/01/20