Re: [Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64

[Alex Bennée]

Greg Bellows <address@hidden> writes:

> On Tue, Jan 20, 2015 at 10:57 AM, Alex Bennée <address@hidden> wrote:
>>
>> Greg Bellows <address@hidden> writes:
>>
>>> Add 32-bit to/from 64-bit register synchronization on register gets and 
>>> puts.
>>> Set EL1_32BIT feature flag passed to KVM
>>>
>>> Signed-off-by: Greg Bellows <address@hidden>
<snip>
>>>      }
>>>
>>>      /* Note that KVM thinks pstate is 64 bit but we use a uint32_t */
>>> -    val = pstate_read(env);
>>> +    if (is_a64(env)) {
>>> +        val = pstate_read(env);
>>> +    } else {
>>> +        val = cpsr_read(env);
>>> +    }
>>
>> I know why we do this (especially given where my attempt ended up) but
>> perhaps we could at list have a single state aware accessor so we don't
>> end up duplicating this test all over the place?
>
> I'd happily add an accessor function, but I only found 1 other
> location that does this conditional so I'm not sure it is warranted.

The migration/serialisation code? Today one other, tomorrow just one more?

-- 
Alex Bennée