[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] ahci: Correct PIO/D2H FIS responses
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] ahci: Correct PIO/D2H FIS responses |
Date: |
Mon, 27 Oct 2014 10:32:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
John Snow <address@hidden> writes:
> Currently, the D2H FIS packets AHCI generates simply parrot back
> the LBA that the guest sent to us in the cmd_fis. However, some
> commands (like READ NATIVE MAX) modify the LBA registers as a
> return value, through which the AHCI D2H FIS is the only response
> mechanism. Thus, the D2H response should use the current register
> values, not the initial ones.
>
> This patch adjusts the LBA and drive select register responses for
> PIO Setup and D2H FIS response packets.
>
> Additionally, the PIO and D2H FIS responses copy too many bytes
> from the command FIS that it is being generated from. Specifically,
> byte 11 which is the Features(15:8) field for Register Host to
> Device FIS packets, is instead reserved for the PIO Setup FIS and
> should always be 0.
Ignorant q: is this based on observation or some specification? If
specification: where can I find a copy?
- [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, John Snow, 2014/10/01
- [Qemu-devel] [PATCH 2/6] ahci: Update byte count after DMA completion, John Snow, 2014/10/01
- [Qemu-devel] [PATCH 3/6] ide: repair PIO transfers for cases where nsector > 1, John Snow, 2014/10/01
- [Qemu-devel] [PATCH 4/6] ahci: unify sglist preparation, John Snow, 2014/10/01
- [Qemu-devel] [PATCH 5/6] ide: Correct handling of malformed/short PRDTs, John Snow, 2014/10/01
- [Qemu-devel] [PATCH 6/6] ahci: Fix SDB FIS Construction, John Snow, 2014/10/01
- Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes, John Snow, 2014/10/16