[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 4/8] pc: add cpu hotplug handler to PC_MACHIN
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH V5 4/8] pc: add cpu hotplug handler to PC_MACHINE |
Date: |
Mon, 20 Oct 2014 16:58:41 +0200 |
On Fri, 10 Oct 2014 10:16:03 +0800
Gu Zheng <address@hidden> wrote:
> Add cpu hotplug handler to PC_MACHINE, which will perform the acpi
> cpu hotplug callback via hotplug_handler API.
>
> Signed-off-by: Gu Zheng <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> v5:
> -split the check out of acpi_dev block.
> v3:
> -deal with start up cpus in a more neat way as Igor suggested.
> v2:
> -just rebase.
>
> hw/i386/pc.c | 28 +++++++++++++++++++++++++++-
> 1 files changed, 27 insertions(+), 1 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index d045e8b..eff19ef 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1617,11 +1617,36 @@ out:
> error_propagate(errp, local_err);
> }
>
> +static void pc_cpu_plug(HotplugHandler *hotplug_dev,
> + DeviceState *dev, Error **errp)
> +{
> + HotplugHandlerClass *hhc;
> + Error *local_err = NULL;
> + PCMachineState *pcms = PC_MACHINE(hotplug_dev);
> +
> + if (!dev->hotplugged) {
> + goto out;
> + }
> +
> + if (!pcms->acpi_dev) {
> + error_setg(&local_err,
> + "cpu hotplug is not enabled: missing acpi device");
> + goto out;
> + }
> +
> + hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev);
> + hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
> +out:
> + error_propagate(errp, local_err);
> +}
> +
> static void pc_machine_device_plug_cb(HotplugHandler *hotplug_dev,
> DeviceState *dev, Error **errp)
> {
> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
> pc_dimm_plug(hotplug_dev, dev, errp);
> + } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> + pc_cpu_plug(hotplug_dev, dev, errp);
> }
> }
>
> @@ -1630,7 +1655,8 @@ static HotplugHandler
> *pc_get_hotpug_handler(MachineState *machine,
> {
> PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(machine);
>
> - if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
> + if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) ||
> + object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> return HOTPLUG_HANDLER(machine);
> }
>
- [Qemu-devel] [PATCH V5 0/8] cpu/acpi: convert cpu hot plug to hotplug_handler API, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 1/8] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 2/8] acpi:ich9: convert cpu hotplug to hotplug_handler API, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 3/8] acpi:piix4: convert cpu hotplug to hotplug_handler API, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 4/8] pc: add cpu hotplug handler to PC_MACHINE, Gu Zheng, 2014/10/09
- Re: [Qemu-devel] [PATCH V5 4/8] pc: add cpu hotplug handler to PC_MACHINE,
Igor Mammedov <=
- [Qemu-devel] [PATCH V5 5/8] pc: Update rtc_cmos in pc_cpu_plug, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 6/8] qom/cpu: remove the unused CPU hot-plug notifier, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 7/8] cpu-hotplug: rename function for better readability, Gu Zheng, 2014/10/09
- [Qemu-devel] [PATCH V5 8/8] acpi/cpu-hotplug: introduce helper function to keep bit setting in one place, Gu Zheng, 2014/10/09
- Re: [Qemu-devel] [PATCH V5 0/8] cpu/acpi: convert cpu hot plug to hotplug_handler API, Gu Zheng, 2014/10/16