Re: [Qemu-devel] [PATCH V5 6/8] qom/cpu: remove the unused CPU hot-plug notifier

[Igor Mammedov]

On Fri, 10 Oct 2014 10:16:05 +0800
Gu Zheng <address@hidden> wrote:

> Remove the unused CPU hot-plug notifier.
> 
> Signed-off-by: Gu Zheng <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
> v5:
>  -delete the caller of notifier_list_notify() in this patch.
> 
>  include/sysemu/sysemu.h |    3 ---
>  qom/cpu.c               |   10 ----------
>  2 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index d8539fd..acfe494 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -183,9 +183,6 @@ void do_pci_device_hot_remove(Monitor *mon, const QDict 
> *qdict);
>  /* generic hotplug */
>  void drive_hot_add(Monitor *mon, const QDict *qdict);
>  
> -/* CPU hotplug */
> -void qemu_register_cpu_added_notifier(Notifier *notifier);
> -
>  /* pcie aer error injection */
>  void pcie_aer_inject_error_print(Monitor *mon, const QObject *data);
>  int do_pcie_aer_inject_error(Monitor *mon,
> diff --git a/qom/cpu.c b/qom/cpu.c
> index 0ec3337..79d2228 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -107,15 +107,6 @@ static void cpu_common_get_memory_mapping(CPUState *cpu,
>      error_setg(errp, "Obtaining memory mappings is unsupported on this 
> CPU.");
>  }
>  
> -/* CPU hot-plug notifiers */
> -static NotifierList cpu_added_notifiers =
> -    NOTIFIER_LIST_INITIALIZER(cpu_add_notifiers);
> -
> -void qemu_register_cpu_added_notifier(Notifier *notifier)
> -{
> -    notifier_list_add(&cpu_added_notifiers, notifier);
> -}
> -
>  void cpu_reset_interrupt(CPUState *cpu, int mask)
>  {
>      cpu->interrupt_request &= ~mask;
> @@ -312,7 +303,6 @@ static void cpu_common_realizefn(DeviceState *dev, Error 
> **errp)
>  
>      if (dev->hotplugged) {
>          cpu_synchronize_post_init(cpu);
> -        notifier_list_notify(&cpu_added_notifiers, dev);
>          cpu_resume(cpu);
>      }
>  }