Re: [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-events

[Markus Armbruster]

Stefan Hajnoczi <address@hidden> writes:

> On Mon, Sep 22, 2014 at 05:45:15PM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi <address@hidden> writes:
>> 
>> > Over time a few unused trace events have been left behind in 
>> > ./trace-events.
>> > Either the code that called them was deleted or the event was
>> > never called in
>> > the first place.
>> >
>> > This is a clear violation of the solider's motto "no man left behind".  
>> > It's
>> > time to bring these trace events home.
>> >
>> > On a more serious note, unused trace events cause confusion to
>> > users who want
>> > to enable existing instrumentation.  On the SystemTap backend we get errors
>> > when attempting to enable them because the static probes that
>> > these events are
>> > based on do not exist.
>> 
>> Reviewed-by: Markus Armbruster <address@hidden>
>> 
>> While you're at it, could you also clean up the pointers to source files
>> that have bit-rotted?
>
> Sure, please post a separate patch with your Signed-off-by and I'll
> merge it.

Done.  Turned into a mini-series.