[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-even
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-events |
Date: |
Wed, 24 Sep 2014 14:38:15 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 22, 2014 at 03:03:12PM +0100, Stefan Hajnoczi wrote:
> Over time a few unused trace events have been left behind in ./trace-events.
> Either the code that called them was deleted or the event was never called in
> the first place.
>
> This is a clear violation of the solider's motto "no man left behind". It's
> time to bring these trace events home.
>
> On a more serious note, unused trace events cause confusion to users who want
> to enable existing instrumentation. On the SystemTap backend we get errors
> when attempting to enable them because the static probes that these events are
> based on do not exist.
>
> Stefan Hajnoczi (3):
> trace-events: drop orphan virtio_blk_data_plane_complete_request
> trace-events: drop orphan usb_mtp_data_out
> trace-events: drop orphan iscsi trace events
>
> block/iscsi.c | 1 -
> trace-events | 8 --------
> 2 files changed, 9 deletions(-)
>
> --
> 1.9.3
>
>
Applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
pgpEd5SvX4qsx.pgp
Description: PGP signature