[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] arm_gic: Do not force PPIs to edge-triggere
From: |
Christoffer Dall |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] arm_gic: Do not force PPIs to edge-triggered mode |
Date: |
Mon, 18 Aug 2014 14:48:15 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Aug 16, 2014 at 09:48:21PM +0200, Adam Lackorzynski wrote:
> Only SGIs must be WI, done by forcing them to their default
> (edge-triggered).
>
> Signed-off-by: Adam Lackorzynski <address@hidden>
> ---
> hw/intc/arm_gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
> index e546647..55019c9 100644
> --- a/hw/intc/arm_gic.c
> +++ b/hw/intc/arm_gic.c
> @@ -558,7 +558,7 @@ static void gic_dist_writeb(void *opaque, hwaddr offset,
> irq = (offset - 0xc00) * 4 + GIC_BASE_IRQ;
> if (irq >= s->num_irq)
> goto bad_reg;
> - if (irq < GIC_INTERNAL)
> + if (irq < GIC_NR_SGIS)
> value |= 0xaa;
> for (i = 0; i < 4; i++) {
> if (s->revision == REV_11MPCORE || s->revision == REV_NVIC) {
> --
> 2.1.0.rc1
>
where do we ensure that the SGIs are actually configured as
edge-triggered when creating the gic?
-Christoffer
[Qemu-devel] [PATCH 2/3] arm_gic: GICD_ICFGR: Write model only for pre v1 GICs, Adam Lackorzynski, 2014/08/16