[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak |
Date: |
Wed, 30 Jul 2014 08:58:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/26/2014 01:22 PM, Max Reitz wrote:
> As soon as options is set in img_amend(), it needs to be freed before
> the function returns. This leak is rather insignifcant, as qemu-img will
s/insignifcant/insignificant/
> exit subsequently anyway, but there's no point in not fixing it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-img.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
1-3 look the same as in the other version of this series, so no further
comments on them. I'll try and review both series to see if either one
makes more sense as being more desirable.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH alt 0/7] block/qcow2: Improve zero cluster expansion, Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 1/7] block: Add status callback to bdrv_amend_options(), Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 2/7] qemu-img: Add progress output for amend, Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak, Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 4/7] block/qcow2: Implement status CB for amend, Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 5/7] block/qcow2: Make get_refcount() global, Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 6/7] block/qcow2: Simplify shared L2 handling in amend, Max Reitz, 2014/07/26
- [Qemu-devel] [PATCH alt 7/7] iotests: Expand test 061, Max Reitz, 2014/07/26