qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH alt 3/7] qemu-img: Fix insignifcant memleak
Date: Wed, 30 Jul 2014 22:08:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 30.07.2014 16:58, Eric Blake wrote:
On 07/26/2014 01:22 PM, Max Reitz wrote:
As soon as options is set in img_amend(), it needs to be freed before
the function returns. This leak is rather insignifcant, as qemu-img will
s/insignifcant/insignificant/

I wonder how I was able to get it wrong the same way twice...

exit subsequently anyway, but there's no point in not fixing it.

Signed-off-by: Max Reitz <address@hidden>
---
  qemu-img.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
1-3 look the same as in the other version of this series, so no further
comments on them. I'll try and review both series to see if either one
makes more sense as being more desirable.

Thank you,

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]