[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb
From: |
Dongxue Zhang |
Subject: |
[Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb |
Date: |
Mon, 28 Jul 2014 23:58:22 +0800 |
Use 'if' to make sure the real msb greater than the lsb. As the compiler may
not do this.
Signed-off-by: Dongxue Zhang <address@hidden>
---
target-mips/translate.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index c381366..e2cce31 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -3946,14 +3946,23 @@ static void gen_bitops (DisasContext *ctx, uint32_t
opc, int rt,
break;
#if defined(TARGET_MIPS64)
case OPC_DINSM:
+ if (lsb > (msb + 32)) {
+ goto fail;
+ }
gen_load_gpr(t0, rt);
tcg_gen_deposit_tl(t0, t0, t1, lsb, msb + 32 - lsb + 1);
break;
case OPC_DINSU:
+ if (lsb > msb) {
+ goto fail;
+ }
gen_load_gpr(t0, rt);
tcg_gen_deposit_tl(t0, t0, t1, lsb + 32, msb - lsb + 1);
break;
case OPC_DINS:
+ if (lsb > msb) {
+ goto fail;
+ }
gen_load_gpr(t0, rt);
tcg_gen_deposit_tl(t0, t0, t1, lsb, msb - lsb + 1);
break;
--
1.8.1.2
- [Qemu-devel] [PATCH 1/2] target-mips/translate.c: Free TCG in OPC_DINSV, Dongxue Zhang, 2014/07/28
- [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb,
Dongxue Zhang <=
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Aurelien Jarno, 2014/07/28
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Peter Maydell, 2014/07/28
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Aurelien Jarno, 2014/07/28
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Peter Maydell, 2014/07/28
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Aurelien Jarno, 2014/07/28
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Elta, 2014/07/29
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Aurelien Jarno, 2014/07/29
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Dongxue Zhang, 2014/07/29
- Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb, Peter Maydell, 2014/07/29
Re: [Qemu-devel] [PATCH 1/2] target-mips/translate.c: Free TCG in OPC_DINSV, Aurelien Jarno, 2014/07/28