[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case o
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults |
Date: |
Fri, 04 Apr 2014 15:14:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 04.04.2014 10:28, schrieb Nikunj A Dadhania:
> diff --git a/vl.c b/vl.c
> index 017f92d..0d6c36c 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4348,7 +4348,8 @@ int main(int argc, char **argv, char **envp)
> .kernel_filename = kernel_filename,
> .kernel_cmdline = kernel_cmdline,
> .initrd_filename = initrd_filename,
> - .cpu_model = cpu_model };
> + .cpu_model = cpu_model,
> + .has_defaults = has_defaults, };
If we do this, please put
};
on the next line so that the next person appending something doesn't
need to touch it again. :)
I do agree with the others that libvirt shouldn't be using the legacy
-usb option.
Cheers,
Andreas
> machine->init(&args);
>
> audio_init();
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, (continued)
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Andreas Färber, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Nikunj A Dadhania, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Andreas Färber, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Markus Armbruster, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Nikunj A Dadhania, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Markus Armbruster, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Markus Armbruster, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Eric Blake, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults,
Andreas Färber <=
Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Eric Blake, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Nikunj A Dadhania, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/03
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Nikunj A Dadhania, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Nikunj A Dadhania, 2014/04/04
- Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults, Paolo Bonzini, 2014/04/04