[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] hmp interface for kdump compressed format
From: |
address@hidden |
Subject: |
Re: [Qemu-devel] hmp interface for kdump compressed format |
Date: |
Thu, 27 Mar 2014 01:22:33 +0000 |
On 03/27/2014 01:04 AM, Markus Armbruster wrote:
>>>>> So something like adding
>>>>> >>>>
>>>>> >>>> dump_guest_memory_set_format<format>
>>>>> >>>>
>>>>> >>>> would be the only possible solution with the hmp code as is.
>>>>> >>>> Correct?
>>>> >>>
>>>> >>> Yes, one possibility would be to make the dump command stateful (=
>>>> >>> compression format), and to add a new command setting/getting that
>>>> >>> state.
>>>> >>>
>>>> >>> Another option would be to leave the current command intact, and add
>>>> >>> an
>>>> >>> independent command that wouldn't take "begin", "end", nor "paging",
>>>> >>> but
>>>> >>> would take compression format.
>>> >>
>>> >> Another possibility is to kill begin/length from the
>>> >> dump-guest-memory command.
>>> >> HMP is not stable, so if that's useful we can do it.
>> >
>> > AFAIK, kdump-compressed format can only be analyzed by crash-utility right
>> > now. ELF is big but we still need it, then begin/length will help us save
>> > time and space when only part of the memory is need.
>> >
>> > IMHO, a new HMP command will be a good choice and it is more simple than
>> > making dump format 'stateful'. I am not so clear about HMP, but I think
>> > the new HMP command can be 'dump-guest-memory-with-format', and still
>> > base on qmp_dump_guest_memory. If you guys like it, I will send a patch
>> > that add this command.
> Paolo encouraged you to*break* the existing HMP command instead of
> adding a new one. I'd like to second that.
> .
>
Hello markus,
I have finish my patch as I stated in my last mail, but something is
wrong with my mail server, I have to wait a couple of days before
sending the patch. You said you prefer *breaking* the existing HMP
command. Since paging/begin/length is still usefull, would you please
give some reason and I will consider that.
--
Regards
Qiao Nuohan
- [Qemu-devel] hmp interface for kdump compressed format, Christian Borntraeger, 2014/03/20
- Re: [Qemu-devel] hmp interface for kdump compressed format, Laszlo Ersek, 2014/03/20
- Re: [Qemu-devel] hmp interface for kdump compressed format, Laszlo Ersek, 2014/03/20
- Re: [Qemu-devel] hmp interface for kdump compressed format, Christian Borntraeger, 2014/03/20
- Re: [Qemu-devel] hmp interface for kdump compressed format, Laszlo Ersek, 2014/03/20
- Re: [Qemu-devel] hmp interface for kdump compressed format, Paolo Bonzini, 2014/03/20
- Re: [Qemu-devel] hmp interface for kdump compressed format, address@hidden, 2014/03/21
- Re: [Qemu-devel] hmp interface for kdump compressed format, Christian Borntraeger, 2014/03/21
- Re: [Qemu-devel] hmp interface for kdump compressed format, Markus Armbruster, 2014/03/26
- Re: [Qemu-devel] hmp interface for kdump compressed format,
address@hidden <=
- Re: [Qemu-devel] hmp interface for kdump compressed format, Markus Armbruster, 2014/03/27