[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/7] allwinner-emac: set autonegotiation comp
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/7] allwinner-emac: set autonegotiation complete bit on link up |
Date: |
Mon, 17 Mar 2014 11:29:18 +1000 |
On Sat, Mar 15, 2014 at 11:01 PM, Beniamino Galvani <address@hidden> wrote:
> Signed-off-by: Beniamino Galvani <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> hw/net/allwinner_emac.c | 4 ++--
> include/hw/net/allwinner_emac.h | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c
> index 469f2f0..91931ac 100644
> --- a/hw/net/allwinner_emac.c
> +++ b/hw/net/allwinner_emac.c
> @@ -27,11 +27,11 @@ static uint8_t padding[60];
> static void mii_set_link(RTL8201CPState *mii, bool link_ok)
> {
> if (link_ok) {
> - mii->bmsr |= MII_BMSR_LINK_ST;
> + mii->bmsr |= MII_BMSR_LINK_ST | MII_BMSR_AN_COMP;
> mii->anlpar |= MII_ANAR_TXFD | MII_ANAR_10FD | MII_ANAR_10 |
> MII_ANAR_CSMACD;
> } else {
> - mii->bmsr &= ~MII_BMSR_LINK_ST;
> + mii->bmsr &= ~(MII_BMSR_LINK_ST | MII_BMSR_AN_COMP);
> mii->anlpar = MII_ANAR_TX;
> }
> }
> diff --git a/include/hw/net/allwinner_emac.h b/include/hw/net/allwinner_emac.h
> index a5e944a..5ae7717 100644
> --- a/include/hw/net/allwinner_emac.h
> +++ b/include/hw/net/allwinner_emac.h
> @@ -144,6 +144,7 @@
> #define MII_BMSR_10T_FD (1 << 12)
> #define MII_BMSR_10T_HD (1 << 11)
> #define MII_BMSR_MFPS (1 << 6)
> +#define MII_BMSR_AN_COMP (1 << 5)
> #define MII_BMSR_AUTONEG (1 << 3)
> #define MII_BMSR_LINK_ST (1 << 2)
>
> --
> 1.7.10.4
>
>
- [Qemu-devel] [PATCH v3 3/7] allwinner-a10-pit: avoid generation of spurious interrupts, (continued)
- [Qemu-devel] [PATCH v3 3/7] allwinner-a10-pit: avoid generation of spurious interrupts, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 7/7] allwinner-emac: update irq status after writes to interrupt registers, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 4/7] allwinner-a10-pit: use level triggered interrupts, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 5/7] allwinner-a10-pit: implement prescaler and source selection, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 6/7] allwinner-emac: set autonegotiation complete bit on link up, Beniamino Galvani, 2014/03/15
- Re: [Qemu-devel] [PATCH v3 6/7] allwinner-emac: set autonegotiation complete bit on link up,
Peter Crosthwaite <=