Re: [Qemu-devel] [v2 PATCH 11/13] SMBIOS: Build full type 19 tables

[Gerd Hoffmann]

On Di, 2014-03-11 at 11:16 -0400, Gabriel L. Somlo wrote:
> From: "Gabriel L. Somlo" <address@hidden>
> 
> Build full smbios type 19 (memory array mapped address) tables,
> and make them available via fw_cfg


> +        smbios_build_type_19_table(0, 0, smbios_below_4g_ram >> 10);
> +        if (smbios_above_4g_ram) {
> +            smbios_build_type_19_table(1, 4 << 20, smbios_above_4g_ram >> 
> 10);
> +        }

I think we should just use e820_table (see pc.c) here.  Loop over it and
add a type 19 table for each ram region in there.

cheers,
  Gerd