Re: [Qemu-devel] [PATCH 0/3] Extract non-QDicts in qdict_array_split()

[Eric Blake]

On 02/21/2014 11:11 AM, Max Reitz wrote:
> Currently, qdict_array_split() splits a QDict like
>   { "0.a": 42, "1": 23, "2.b": 84 }
> into the QList
>   [ { "a": 42 } ]
> with the QDict still being
>   { "1": 23, "2.b": 84 }
> 
> However, it makes more sense to create the QList
>   [ { "a": 42 }, 23, { "b": 84 } ]
> and having emptied the QDict.
> 
> This is implemented by this series.
> 

Question - in the code, we have a comment:

/**
 * qdict_flatten(): For each nested QDict with key x, all fields with key y
 * are moved to this QDict and their key is renamed to "x.y". For each
nested
 * QList with key x, the field at index y is moved to this QDict with
the key
 * "x.y" (i.e., the reverse of what qdict_array_split() does).
 * This operation is applied recursively for nested QDicts and QLists.
 */

With your new split rules, do we need a followup patch to qdict_flatten
that can regenerate the QDict with "%u" keys for non-dict members of the
QList?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature