[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for qdict_array_sp
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for qdict_array_split() |
|
Date: |
Fri, 21 Feb 2014 11:39:56 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 11:11 AM, Max Reitz wrote:
> Test the new functionality of qdict_array_split(), that is, splitting
> off single objects.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/check-qdict.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
However, I think it is incomplete - you didn't test the behavior when
both %u and %u.sub appear in the same dict, to make sure the splitting
stops at that point.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] Extract non-QDicts in qdict_array_split(), Max Reitz, 2014/02/21
- [Qemu-devel] [PATCH 1/3] qemu-config: Sections must consist of keys, Max Reitz, 2014/02/21
- [Qemu-devel] [PATCH 2/3] qdict: Extract non-QDicts in qdict_array_split(), Max Reitz, 2014/02/21
- [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for qdict_array_split(), Max Reitz, 2014/02/21
- Re: [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for qdict_array_split(),
Eric Blake <=
- Re: [Qemu-devel] [PATCH 0/3] Extract non-QDicts in qdict_array_split(), Kevin Wolf, 2014/02/21
- Re: [Qemu-devel] [PATCH 0/3] Extract non-QDicts in qdict_array_split(), Eric Blake, 2014/02/21