[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init |
Date: |
Sun, 9 Feb 2014 06:06:33 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Feb 09, 2014 at 12:10:20AM +0000, Peter Maydell wrote:
> On 8 February 2014 23:33, Paolo Bonzini <address@hidden> wrote:
> > Il 08/02/2014 18:28, Andreas Färber ha scritto:
> >> Since when is it OK to declare variables in the middle of the block?
>
> > When the code looks better, it is OK since always: checkpatch.pl doesn't
> > complain and -Wdeclaration-after-statement is not added to the compiler
> > flags.
>
> Huh? checkpatch is notoriously not a reliable guide, and we've had
> the "declarations at start of block" rule since forever.
Sorry for my confusion, but I was not aware of that rule, and I don't
know what I should use as a guide, if checkpatch.pl and CODING_STYLE are
not enough. Is there additional coding style documentation or scripts I
should look at?
--
Eduardo
- [Qemu-devel] [PULL 12/16] kvm: make hyperv vapic assist page migratable, (continued)
- [Qemu-devel] [PULL 12/16] kvm: make hyperv vapic assist page migratable, Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/03
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Andreas Färber, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Peter Maydell, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Peter Maydell, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/09
- [Qemu-devel] [PATCH] target-i386: Don't declare variables in the middle of blocks, Eduardo Habkost, 2014/02/09
- [Qemu-devel] [qom-cpu PATCH v2] target-i386: Don't declare variables in the middle of blocks, Eduardo Habkost, 2014/02/19
- Re: [Qemu-devel] [qom-cpu PATCH v2] target-i386: Don't declare variables in the middle of blocks, Andreas Färber, 2014/02/20
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init,
Eduardo Habkost <=
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Andreas Färber, 2014/02/09
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Peter Maydell, 2014/02/09
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Andreas Färber, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/09
Re: [Qemu-devel] [PULL 00/16] KVM changes for 2014-02-03, Peter Maydell, 2014/02/06