[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 09/11] stream: Use bdrv_drop_intermediate and dr
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v12 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images |
Date: |
Mon, 27 Jan 2014 11:48:15 +0800 |
This reuses the new bdrv_drop_intermediate.
Signed-off-by: Fam Zheng <address@hidden>
---
block/stream.c | 30 +-----------------------------
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index dd0b4ac..9cdcf0e 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -51,34 +51,6 @@ static int coroutine_fn stream_populate(BlockDriverState *bs,
return bdrv_co_copy_on_readv(bs, sector_num, nb_sectors, &qiov);
}
-static void close_unused_images(BlockDriverState *top, BlockDriverState *base,
- const char *base_id)
-{
- BlockDriverState *intermediate;
- intermediate = top->backing_hd;
-
- /* Must assign before bdrv_delete() to prevent traversing dangling pointer
- * while we delete backing image instances.
- */
- top->backing_hd = base;
-
- while (intermediate) {
- BlockDriverState *unused;
-
- /* reached base */
- if (intermediate == base) {
- break;
- }
-
- unused = intermediate;
- intermediate = intermediate->backing_hd;
- unused->backing_hd = NULL;
- bdrv_unref(unused);
- }
-
- bdrv_refresh_limits(top);
-}
-
static void coroutine_fn stream_run(void *opaque)
{
StreamBlockJob *s = opaque;
@@ -192,7 +164,7 @@ wait:
}
}
ret = bdrv_change_backing_file(bs, base_id, base_fmt);
- close_unused_images(bs, base, base_id);
+ bdrv_drop_intermediate(bs, bs->backing_hd, base);
}
qemu_vfree(buf);
--
1.8.5.3
- [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 01/11] block: Add BlockOpType enum, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 02/11] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 03/11] block: Replace in_use with operation blocker, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 04/11] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd(), Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 06/11] block: Add backing_blocker in BlockDriverState, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 07/11] block: Parse "backing" option to reference existing BDS, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 08/11] block: Support dropping active in bdrv_drop_intermediate, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images,
Fam Zheng <=
- [Qemu-devel] [PATCH v12 10/11] qmp: Add command 'blockdev-backup', Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 11/11] block: Allow backup on referenced named BlockDriverState, Fam Zheng, 2014/01/26
- Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Stefan Hajnoczi, 2014/01/28
- Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Fam Zheng, 2014/01/28
- Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Stefan Hajnoczi, 2014/01/28