[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd() |
Date: |
Tue, 28 Jan 2014 18:09:39 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 27, 2014 at 11:48:11AM +0800, Fam Zheng wrote:
> + pstrcpy(bs->backing_file, sizeof(bs->backing_file),
> backing_hd->filename);
> + pstrcpy(bs->backing_format, sizeof(bs->backing_file),
> + backing_hd->drv ? backing_hd->drv->format_name : "");
> + bdrv_ref(bs->backing_hd);
> +
> + pstrcpy(bs->backing_file, sizeof(bs->backing_file),
> + bs->backing_hd->file->filename);
> + pstrcpy(bs->backing_format, sizeof(bs->backing_format),
> + bs->backing_hd->drv->format_name);
This is redundant, you already have the same above?
- [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 01/11] block: Add BlockOpType enum, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 02/11] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 03/11] block: Replace in_use with operation blocker, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 04/11] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd(), Fam Zheng, 2014/01/26
- Re: [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v12 06/11] block: Add backing_blocker in BlockDriverState, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 07/11] block: Parse "backing" option to reference existing BDS, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 08/11] block: Support dropping active in bdrv_drop_intermediate, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images, Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 10/11] qmp: Add command 'blockdev-backup', Fam Zheng, 2014/01/26
- [Qemu-devel] [PATCH v12 11/11] block: Allow backup on referenced named BlockDriverState, Fam Zheng, 2014/01/26
- Re: [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Stefan Hajnoczi, 2014/01/28