[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttri
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes |
|
Date: |
Mon, 16 Dec 2013 12:43:20 +0100 |
On Mo, 2013-12-16 at 11:36 +0200, Pantelis Koukousoulas wrote:
> Replace magic constants in device bmAttributes with symbolic ones
> from Linux kernel ch9.h
> - .bmAttributes = 0xc0,
> + .bmAttributes = USB_CONFIG_ATT_ONE |
> USB_CONFIG_ATT_SELFPOWER,
Looks good, but fails checkpatch with lots of "WARNING: line over 80
characters" messages.
cheers,
Gerd