Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes

[Pantelis Koukousoulas]

I thought that for lines that are just a logical or of constants
it would be ok to go over 80 columns, since the alternatives

(shortening the names of constants or breaking the line)

are a little less readable.

How about the attached patch instead, I shortened the names

by using CFG instead of CONFIG and broke the two lines
that were still longer than 80 columns, now checkpatch.pl

seems happy :)

Cheers,

Pantelis

On Mon, Dec 16, 2013 at 1:43 PM, Gerd Hoffmann <address@hidden> wrote:

On Mo, 2013-12-16 at 11:36 +0200, Pantelis Koukousoulas wrote:
> Replace magic constants in device bmAttributes with symbolic ones
> from Linux kernel ch9.h

> -            .bmAttributes          = 0xc0,
> +            .bmAttributes          = USB_CONFIG_ATT_ONE | USB_CONFIG_ATT_SELFPOWER,

Looks good, but fails checkpatch with lots of "WARNING: line over 80
characters" messages.

cheers,
  Gerd

0001-usb-Remove-magic-constants-from-device-bmAttributes.patch
Description: Text Data