[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error" |
Date: |
Fri, 13 Dec 2013 14:00:55 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/13/2013 01:49 PM, Kevin Wolf wrote:
> Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
>> Introduce an alias "error" for "errno", since using the latter for QMP
>> is sure to result in various syntax errors due to the name being used
>> directly as an identifier.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>
> I can't say I like this, but it seems we don't have an option.
Don't we already have a way to use QMP keys that collide with C keywords
(for example, "unix" in qapi's SocketAddress becomes "q_unix" in C)?
Why can't we reuse that mechanism, and just add "errno" to the polluted
words list so that the generated C code uses "q_errno" rather than
having to invent an "error" alias?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error", Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify, Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 21/22] qemu-io: Make filename optional, Max Reitz, 2013/12/13
[Qemu-devel] [PATCH v5 22/22] iotests: Test new blkdebug/blkverify interface, Max Reitz, 2013/12/13