qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and b

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify
Date: Fri, 13 Dec 2013 14:03:13 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 
On 12/13/2013 01:54 PM, Kevin Wolf wrote:
> Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:

>> +# @BlkdebugInjectErrorOptions
>> +#
>> +# Describes a single error injection for blkdebug.
>> +#
>> +# @event:       trigger event name
>> +#

>> +##
>> +{ 'type': 'BlkdebugInjectErrorOptions',
>> +  'data': { 'event': 'str',
> 
> I bet Eric will tell you that an enum for event would be much nicer. ;-)

Am I that predictable?  :)

And see my comments on 19; I think with a minor tweak to qapi.py's
polluted_words, that you could use @errno instead of @error.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]