[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in
|
From: |
Claudio Fontana |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op |
|
Date: |
Thu, 12 Sep 2013 16:31:00 +0200 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 12.09.2013 16:02, Richard Henderson wrote:
> On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>>> + case INDEX_op_mov_i64:
>>> + case INDEX_op_mov_i32:
>>> + case INDEX_op_movi_i64:
>>> + case INDEX_op_movi_i32:
>>> + /* Always implemented with tcg_out_mov/i, never with tcg_out_op.
>>> */
>>> default:
>>> - tcg_abort(); /* opcode not implemented */
>>> + /* Opcode not implemented. */
>>> + tcg_abort();
>>> }
>>> }
>>>
>>
>> Ok
>
> Sadly, "Ok" is neither Reviewed-by or Signed-off-by.
>
>
There is nothing sad about it. When it's reviewed, you will know.
[Qemu-devel] [PATCH v3 04/29] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 05/29] tcg-aarch64: Change enum aarch64_arith_opc to AArch64Insn, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 02/29] tcg-aarch64: Change all ext variables to bool, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 07/29] tcg-aarch64: Introduce tcg_fmt_* functions, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 06/29] tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insn, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 08/29] tcg-aarch64: Introduce tcg_fmt_Rdn_aimm, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 09/29] tcg-aarch64: Implement mov with tcg_fmt_* functions, Richard Henderson, 2013/09/02