qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 02/29] tcg-aarch64: Change all ext variables


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 02/29] tcg-aarch64: Change all ext variables to bool
Date: Thu, 12 Sep 2013 06:45:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/12/2013 01:29 AM, Claudio Fontana wrote:
> I see the problem related to the previous patch.
> What about continuing to use int in the previous patch,
> and replace it with bool in this one? The previous patch would only target 
> the way ext is set,
> and this one would really contain all bool changes.

For the next edition, I'm planning to swap the order of the first two
patches, and also quit using bool.

I think TCGType is a bit more descriptive here, and also uses the
same 0/1 values that we want.  I added a QEMU_BUILD_BUG_ON to assert
that the enum values don't change.



r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]