[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements |
Date: |
Mon, 9 Sep 2013 17:02:07 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 09.09.2013 16:08, Richard Henderson wrote:
> On 09/09/2013 01:13 AM, Claudio Fontana wrote:
>> after carefully reading and testing your patches, this is how I suggest to
>> proceed:
>>
>> first do the implementation of the new functionality (tcg opcodes, jit) in a
>> way that is consistent with the existing code.
>> No type changes, no refactoring, no beautification.
>>
>> Once we agree on those, introduce the meaningful restructuring you want to
>> do,
>> like the new INSN type, the "don't handle mov/movi in tcg_out_op", the
>> TCG_OPF_64BIT thing, etc.
>>
>> Last do the cosmetic stuff if you really want to do it, like the change all
>> ext to bool (note that there is no point if the callers still use "1" and
>> "0": adapt them as well) etc.
>
> No, I don't agree. Especially with respect to the insn type.
>
> I'd much rather do all the "cosmetic stuff", as you put it, first. It makes
> all of the "real" changes much easier to understand.
>
>
> r~
>
I guess we are stuck then. With the cosmetic and restructuring stuff coming
before, I cannot cherry pick the good parts later.
- [Qemu-devel] [PATCH v3 25/29] tcg-aarch64: Use symbolic names for branches, (continued)
- [Qemu-devel] [PATCH v3 25/29] tcg-aarch64: Use symbolic names for branches, Richard Henderson, 2013/09/02
- [Qemu-devel] [PATCH v3 27/29] tcg-aarch64: Reuse FP and LR in translated code, Richard Henderson, 2013/09/02
- [Qemu-devel] [PATCH v3 26/29] tcg-aarch64: Implement tcg_register_jit, Richard Henderson, 2013/09/02
- [Qemu-devel] [PATCH v3 28/29] tcg-aarch64: Introduce tcg_out_ldst_pair, Richard Henderson, 2013/09/02
- [Qemu-devel] [PATCH v3 29/29] tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check, Richard Henderson, 2013/09/02
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard W.M. Jones, 2013/09/03
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard Henderson, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements,
Claudio Fontana <=
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Peter Maydell, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard Henderson, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/10
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Peter Maydell, 2013/09/10
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/12
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Peter Maydell, 2013/09/12
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard Henderson, 2013/09/10
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/12