[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements |
Date: |
Thu, 12 Sep 2013 10:11:01 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 10.09.2013 15:16, Richard Henderson wrote:
> On 09/10/2013 01:27 AM, Claudio Fontana wrote:
>> There are two aspects.
>>
>> On one side, although some changes do not break anything, I see some
>> problems in them.
>
> Then let us discuss them, sooner rather than later.
>
>> Putting them as a prerequisite for the rest forces us to agreeing on
>> everything before moving forward, instead of being able to agree on separate
>> chunks (meat first, rest later). In my view, this makes the process longer.
>
> If we have no common ground on how the port should look, then we simply cannot
> move forward full stop.
>
> Having put together a foundation of AArch64Insn and tcg_fmt_*, that I believe
> to be clean and easy to understand, I simply refuse on aesthetic grounds to
on aesthetic grounds?
> rewrite later patches to instead use the magic number and open-coded insn
> format used throughout the port today. That way leads to a much greater
> chance
> of error in my opinion.
>
I just asked you to reorder the way you do things, so that I had less work to
do when dissecting problems in the actual functional changes.
If it's really impossible for you to do that, I guess we can move forward
anyway, it just creates more work here before we can have a chunk we agree on.
I will put additional comments on the parts that I would like to see improved.
Thanks,
Claudio
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, (continued)
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard Henderson, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Peter Maydell, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard Henderson, 2013/09/09
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/10
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Peter Maydell, 2013/09/10
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Claudio Fontana, 2013/09/12
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements, Richard Henderson, 2013/09/10
- Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements,
Claudio Fontana <=