[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 09/33] tcg-ppc64: Cleanup tcg_out_movi
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v5 09/33] tcg-ppc64: Cleanup tcg_out_movi |
Date: |
Mon, 15 Apr 2013 20:40:48 +0200 |
The test for using movi32 was sub-optimal for TCG_TYPE_I32, comparing
a signed 32-bit quantity against an unsigned 32-bit quantity.
When possible, use addi+oris for 32-bit unsigned constants. Otherwise,
standardize on addi+oris+ori instead of addis+ori+rldicl.
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/ppc64/tcg-target.c | 41 +++++++++++++++++------------------------
1 file changed, 17 insertions(+), 24 deletions(-)
diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index 822eb07..c6ff75b 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -480,32 +480,25 @@ static void tcg_out_movi32(TCGContext *s, TCGReg ret,
int32_t arg)
}
}
-static void tcg_out_movi (TCGContext *s, TCGType type,
- TCGReg ret, tcg_target_long arg)
+static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg ret,
+ tcg_target_long arg)
{
- int32_t arg32 = arg;
- arg = type == TCG_TYPE_I32 ? arg & 0xffffffff : arg;
-
- if (arg == arg32) {
- tcg_out_movi32 (s, ret, arg32);
- }
- else {
- if ((uint64_t) arg >> 32) {
- uint16_t h16 = arg >> 16;
- uint16_t l16 = arg;
-
- tcg_out_movi32(s, ret, arg >> 32);
+ if (type == TCG_TYPE_I32 || arg == (int32_t)arg) {
+ tcg_out_movi32(s, ret, arg);
+ } else if (arg == (uint32_t)arg && !(arg & 0x8000)) {
+ tcg_out32(s, ADDI | TAI(ret, 0, arg));
+ tcg_out32(s, ORIS | SAI(ret, ret, arg >> 16));
+ } else {
+ int32_t high = arg >> 32;
+ tcg_out_movi32(s, ret, high);
+ if (high) {
tcg_out_shli64(s, ret, ret, 32);
- if (h16) {
- tcg_out32(s, ORIS | SAI(ret, ret, h16));
- }
- if (l16) {
- tcg_out32(s, ORI | SAI(ret, ret, l16));
- }
- } else {
- tcg_out_movi32 (s, ret, arg32);
- if (arg32 < 0)
- tcg_out_ext32u(s, ret, ret);
+ }
+ if (arg & 0xffff0000) {
+ tcg_out32(s, ORIS | SAI(ret, ret, arg >> 16));
+ }
+ if (arg & 0xffff) {
+ tcg_out32(s, ORI | SAI(ret, ret, arg));
}
}
}
--
1.8.1.4
- [Qemu-devel] [PATCH v5 00/33] Modernize tcg/ppc64, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 01/33] disas: Disassemble all ppc insns for the host, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 02/33] tcg-ppc64: Use TCGReg everywhere, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 03/33] tcg-ppc64: Introduce and use tcg_out_rlw, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 04/33] tcg-ppc64: Introduce and use tcg_out_ext32u, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 05/33] tcg-ppc64: Introduce and use tcg_out_shli64, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 06/33] tcg-ppc64: Introduce and use tcg_out_shri64, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 07/33] tcg-ppc64: Introduce and use TAI and SAI, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 08/33] tcg-ppc64: Fix setcond_i32, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 09/33] tcg-ppc64: Cleanup tcg_out_movi,
Richard Henderson <=
- [Qemu-devel] [PATCH v5 10/33] tcg-ppc64: Rearrange integer constant constraints, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 11/33] tcg-ppc64: Improve constant add and sub ops., Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 12/33] tcg-ppc64: Allow constant first argument to sub, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 13/33] tcg-ppc64: Tidy or and xor patterns., Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 14/33] tcg-ppc64: Improve and_i32 with constant, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 15/33] tcg-ppc64: Improve and_i64 with constant, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 16/33] tcg-ppc64: Use automatic implementation of ext32u_i64, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 17/33] tcg-ppc64: Streamline qemu_ld/st insn selection, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 18/33] tcg-ppc64: Implement rotates, Richard Henderson, 2013/04/15
- [Qemu-devel] [PATCH v5 19/33] tcg-ppc64: Implement bswap16 and bswap32, Richard Henderson, 2013/04/15