[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [0/48] target-ppc: MMU implementation cleanup for hash
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [0/48] target-ppc: MMU implementation cleanup for hash MMUs |
Date: |
Thu, 21 Mar 2013 14:43:44 +0100 |
On 12.03.2013, at 11:31, David Gibson wrote:
> This large patch series makes a serious overhaul of the MMU
> implementation for target-ppc. Previously all the quite dissimilar
> PowerPC MMU variants attempted to use a more-or-less common code path,
> with dependencies on env->mmu_model scattered throughout. The
> resulting confused code was not worth the handful of saved lines.
>
> This series starts the transition to a new model, where the different
> MMU types are represented by appropriate QOM methods on the CPU
> object. For now, only the main translation path - previously
> cpu_ppc_handle_mmu_fault() is made such a method, but more could be
> added in future. For now, 32-bit and 64-bit hash page table based
> MMUs (the "classic" PPC MMUs) are given their own handle_mmu_fault
> functions - the remaining MMU types retain the old code for now, I'm
> hoping those more familiar with them will perform a similar conversion
> in future though.
>
> There's plenty more cleanup that could be done. As well as the
> obvious work to convert other MMU types, there's room for improvement
> in: handling of SDR1 and other SPRs, handling of segment registers,
> switching MMU code to user PowerPCCPU instead of CPUPPCState, remove
> the duplicate mmu_model in PowerpCCPUClass and CPUPPCState, removing
> remaining uses of mmu_model. But if I tackled all those now, I might
> never get this series ready.
Thanks a lot, applied all to ppc-next :). With a few 32-bit host fixes. I'll
only push it out once the other TCG breakage is solved, so that I can verify
this actually works on 32-bit hosts (it fails there today, but very very likely
not due to your patches)
Alex
- [Qemu-devel] [PATCH 29/48] mmu-hash64: Clean up ppc_hash64_htab_lookup(), (continued)
- [Qemu-devel] [PATCH 29/48] mmu-hash64: Clean up ppc_hash64_htab_lookup(), David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 41/48] mmu-hash*: Clean up real address calculation, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 48/48] target-ppc: Use QOM method dispatch for MMU fault handling, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 45/48] mmu-hash64: Implement Virtual Page Class Key Protection, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 40/48] mmu-hash*: Clean up PTE flags update, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 47/48] target-ppc: Move ppc tlb_fill implementation into mmu_helper.c, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 44/48] mmu-hash*: Merge translate and fault handling functions, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 46/48] target-ppc: Split user only code out of mmu_helper.c, David Gibson, 2013/03/12
- [Qemu-devel] [PATCH 43/48] mmu-hash*: Don't use full ppc_hash{32, 64}_translate() path for get_phys_page_debug(), David Gibson, 2013/03/12
- Re: [Qemu-devel] [0/48] target-ppc: MMU implementation cleanup for hash MMUs,
Alexander Graf <=