[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeu
From: |
li guang |
Subject: |
Re: [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler |
Date: |
Mon, 18 Mar 2013 16:34:31 +0800 |
在 2013-03-18一的 09:31 +0100,Andreas Färber写道:
> Am 13.03.2013 09:01, schrieb liguang:
> > Signed-off-by: liguang <address@hidden>
> > ---
> > hw/qdev-core.h | 9 +++++
> > hw/qdev.c | 96
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 105 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/qdev-core.h b/hw/qdev-core.h
> > index e69c50b..805ac69 100644
> > --- a/hw/qdev-core.h
> > +++ b/hw/qdev-core.h
> > @@ -262,6 +262,15 @@ void qdev_reset_all(DeviceState *dev);
> > void qbus_reset_all(BusState *bus);
> > void qbus_reset_all_fn(void *opaque);
> >
> > +void qdev_power_on(DeviceState *dev);
> > +void qdev_power_off(DeviceState *dev);
> > +void qdev_power_wakeup(DeviceState *dev);
> > +void qdev_power_suspend(DeviceState *dev);
>
> No new qdev_ functions please. qdev no longer exists in its original
> form since the QOM introduction. Please use device_ instead.
>
> Note that here you use power_*, so it may be worth using an identical
> callback field name for at least on and off if we go with your concept.
>
> Andreas
Good suggestion!
Thanks!
>
> > +void qbus_power_off(void *opaque);
> > +void qbus_power_wakeup(void *opaque);
> > +void qbus_power_suspend(void *opaque);
> > +void qbus_power_on(void *opaque);
> > +
> > void qbus_free(BusState *bus);
> >
> > #define FROM_QBUS(type, dev) DO_UPCAST(type, qbus, dev)
> [snip]
>
- [Qemu-devel] [PATCH][RFC 0/14] implement power chip, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 03/14] qdev: remove redundant abort(), liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 02/14] qdev: add power management method, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 07/14] acpi: refactor acpi wakeup function, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 09/14] ich9: do lpc's power on by reset function, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 01/14] gitignore: ignore more files, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 06/14] sysemu: remove PowerReason in sysemu.h, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 10/14] piix4: refactor piix4's power callbacks, liguang, 2013/03/13