Re: [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler

[Andreas Färber]

Am 13.03.2013 09:01, schrieb liguang:
> Signed-off-by: liguang <address@hidden>
> ---
>  hw/qdev-core.h |    9 +++++
>  hw/qdev.c      |   96 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 105 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/qdev-core.h b/hw/qdev-core.h
> index e69c50b..805ac69 100644
> --- a/hw/qdev-core.h
> +++ b/hw/qdev-core.h
> @@ -262,6 +262,15 @@ void qdev_reset_all(DeviceState *dev);
>  void qbus_reset_all(BusState *bus);
>  void qbus_reset_all_fn(void *opaque);
>  
> +void qdev_power_on(DeviceState *dev);
> +void qdev_power_off(DeviceState *dev);
> +void qdev_power_wakeup(DeviceState *dev);
> +void qdev_power_suspend(DeviceState *dev);

No new qdev_ functions please. qdev no longer exists in its original
form since the QOM introduction. Please use device_ instead.

Note that here you use power_*, so it may be worth using an identical
callback field name for at least on and off if we go with your concept.

Andreas

> +void qbus_power_off(void *opaque);
> +void qbus_power_wakeup(void *opaque);
> +void qbus_power_suspend(void *opaque);
> +void qbus_power_on(void *opaque);
> +
>  void qbus_free(BusState *bus);
>  
>  #define FROM_QBUS(type, dev) DO_UPCAST(type, qbus, dev)
[snip]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg