qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros
Date: Sun, 24 Feb 2013 11:31:29 +0000

On 24 February 2013 11:27, Andreas Färber <address@hidden> wrote:
> Am 22.02.2013 19:22, schrieb Peter Maydell:
>> Yeah, I deliberately dropped a bunch of what I felt were
>> extraneous blank lines :-)
>
> I've applied it to qom-cpu since it conflicts with my additions of
> vmstate_..._cpu fields and ..._do_interrupt() functions.
>
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu
>
> But I will remind you of you messing with my coding style next time you
> ask me to redo any ifs to your liking. May Markus be my witness. Either
> we respect each other's style in cross-target refactorings or we don't.

In this case I actually kind of 50% thought they were the
result of conflicts/merge process rather than intentional,
which is why I cleaned them up. I don't actually care one
way or the other, so you can reinstate them if you prefer.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]