[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros |
Date: |
Fri, 22 Feb 2013 18:22:01 +0000 |
On 22 February 2013 18:20, Andreas Färber <address@hidden> wrote:
> Am 22.02.2013 19:10, schrieb Peter Maydell:
>> From: Andreas Färber <address@hidden>
>> index c0f6c6d..252bd14 100644
>> --- a/target-alpha/cpu-qom.h
>> +++ b/target-alpha/cpu-qom.h
>> @@ -72,5 +72,6 @@ static inline AlphaCPU *alpha_env_get_cpu(CPUAlphaState
>> *env)
>>
>> #define ENV_GET_CPU(e) CPU(alpha_env_get_cpu(e))
>>
>> +#define ENV_OFFSET offsetof(AlphaCPU, env)
>>
>> #endif
> [snip]
>
> Compared to my rebased copy of this patch on qom-cpu-10 yours is
> dropping a white line per target. I've intentionally used two lines
> spacing for grouping and a line between definitions. Matter of taste.
Yeah, I deliberately dropped a bunch of what I felt were
extraneous blank lines :-)
-- PMM
- [Qemu-devel] [PATCH 4/6] Handle CPU interrupts by inline checking of a flag, (continued)
- [Qemu-devel] [PATCH 6/6] gen-icount.h: Rename gen_icount_start/end to gen_tb_start/end, Peter Maydell, 2013/02/22
- [Qemu-devel] [PATCH 5/6] translate-all.c: Remove cpu_unlink_tb(), Peter Maydell, 2013/02/22
- [Qemu-devel] [PATCH 3/6] cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC, Peter Maydell, 2013/02/22
- [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Peter Maydell, 2013/02/22
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Andreas Färber, 2013/02/22
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Andreas Färber, 2013/02/24
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Peter Maydell, 2013/02/24
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Andreas Färber, 2013/02/24
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Peter Maydell, 2013/02/24
- Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros, Andreas Färber, 2013/02/24
Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb(), Richard Henderson, 2013/02/22