[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 31/41] qemu-file: check exit status when closing
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 31/41] qemu-file: check exit status when closing a pipe QEMUFile |
Date: |
Thu, 21 Feb 2013 09:44:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/15/2013 07:47 PM, Paolo Bonzini wrote:
> This is what exec_close does. Move this to the underlying QEMUFile.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> migration-exec.c | 4 ----
> savevm.c | 3 +++
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/migration-exec.c b/migration-exec.c
> index 5dc7313..a2b5f8d 100644
> --- a/migration-exec.c
> +++ b/migration-exec.c
> @@ -50,10 +50,6 @@ static int exec_close(MigrationState *s)
> ret = qemu_fclose(s->opaque);
> s->opaque = NULL;
> s->fd = -1;
> - if (ret >= 0 && !(WIFEXITED(ret) && WEXITSTATUS(ret) == 0)) {
> - /* close succeeded, but non-zero exit code: */
> - ret = -EIO; /* fake errno value */
> - }
> return ret;
> }
>
> diff --git a/savevm.c b/savevm.c
> index 261d17a..f593acd 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -247,6 +247,9 @@ static int stdio_pclose(void *opaque)
> ret = pclose(s->stdio_file);
> if (ret == -1) {
> ret = -errno;
> + } else if (!WIFEXITED(ret) || WEXITSTATUS(ret) != 0) {
> + /* close succeeded, but non-zero exit code: */
> + ret = -EIO; /* fake errno value */
> }
> g_free(s);
> return ret;
>
Reviewed-by: Orit Wasserman <address@hidden>
- [Qemu-devel] [PATCH 25/41] migration: eliminate last_round, (continued)
- [Qemu-devel] [PATCH 25/41] migration: eliminate last_round, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 26/41] migration: detect error before sleeping, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 30/41] qemu-file: fsync a writable stdio QEMUFile, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 31/41] qemu-file: check exit status when closing a pipe QEMUFile, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 39/41] migration: move contents of migration_close to migrate_fd_cleanup, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 36/41] migration: use qemu_ftell to compute bandwidth, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 38/41] migration: move rate limiting to QEMUFile, Paolo Bonzini, 2013/02/15