[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 36/41] migration: use qemu_ftell to compute band
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 36/41] migration: use qemu_ftell to compute bandwidth |
Date: |
Fri, 22 Feb 2013 14:12:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/15/2013 07:47 PM, Paolo Bonzini wrote:
> Prepare for when s->bytes_xfer will be removed.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> migration.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 68d47cd..d636c59 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -575,6 +575,7 @@ static void *migration_thread(void *opaque)
> {
> MigrationState *s = opaque;
> int64_t initial_time = qemu_get_clock_ms(rt_clock);
> + int64_t initial_bytes = 0;
> int64_t max_size = 0;
> int64_t start_time = initial_time;
> bool old_vm_running = false;
> @@ -613,7 +614,7 @@ static void *migration_thread(void *opaque)
> break;
> }
> if (current_time >= initial_time + BUFFER_DELAY) {
> - uint64_t transferred_bytes = s->bytes_xfer;
> + uint64_t transferred_bytes = qemu_ftell(s->file) - initial_bytes;
> uint64_t time_spent = current_time - initial_time;
> double bandwidth = transferred_bytes / time_spent;
> max_size = bandwidth * migrate_max_downtime() / 1000000;
> @@ -624,6 +625,7 @@ static void *migration_thread(void *opaque)
>
> s->bytes_xfer = 0;
> initial_time = current_time;
> + initial_bytes = qemu_ftell(s->file);
> }
> if (qemu_file_rate_limit(s->file)) {
> /* usleep expects microseconds */
>
Reviewed-by: Orit Wasserman <address@hidden>
- Re: [Qemu-devel] [PATCH 30/41] qemu-file: fsync a writable stdio QEMUFile, (continued)
- [Qemu-devel] [PATCH 31/41] qemu-file: check exit status when closing a pipe QEMUFile, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 39/41] migration: move contents of migration_close to migrate_fd_cleanup, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 36/41] migration: use qemu_ftell to compute bandwidth, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 38/41] migration: move rate limiting to QEMUFile, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 41/41] migration: inline migrate_fd_close, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 40/41] migration: eliminate s->migration_file, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 17/41] block-migration: document usage of state across threads, Paolo Bonzini, 2013/02/15