[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] target-i386:define name of breakpoint bi
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] target-i386:define name of breakpoint bit in dr7 |
Date: |
Fri, 11 Jan 2013 17:00:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Hi Guang,
Am 11.01.2013 02:47, schrieb li guang:
> can these patches get an ack from you?
I'm waiting on feedback from the previous reviewers... CC'ing.
> or they were obsoleted?
No, I don't spot any need to rebase. However, patch 3/3 is tab-damaged,
please run scripts/checkpatch.pl. That can be automated as a git hook.
Regards,
Andreas
> 在 2012-12-10一的 10:22 +0800,liguang写道:
>> Signed-off-by: liguang <address@hidden>
>> ---
>> target-i386/cpu.h | 7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
>> index 90ef1ff..29245d1 100644
>> --- a/target-i386/cpu.h
>> +++ b/target-i386/cpu.h
>> @@ -231,6 +231,13 @@
>> #define DR7_TYPE_SHIFT 16
>> #define DR7_LEN_SHIFT 18
>> #define DR7_FIXED_1 0x00000400
>> +#define DR7_LOCAL_BP_MASK 0x55
>> +#define DR7_MAX_BP 4
>> +#define DR7_TYPE_BP_INST 0x0
>> +#define DR7_TYPE_DATA_WR 0x1
>> +#define DR7_TYPE_IO_RW 0x2
>> +#define DR7_TYPE_DATA_RW 0x3
>> +
>>
>> #define PG_PRESENT_BIT 0
>> #define PG_RW_BIT 1
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg