Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

[Kevin Wolf]

Am 11.01.2013 15:40, schrieb Stefan Hajnoczi:
> On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote:
>> Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto:
>>> +        iov = &bounce_iov;
>>> +        iov_cnt = 1;
>>> +
>>> +        if (read) {
>>> +            /* Need to copy back from bounce buffer on completion */
>>> +            read_qiov = g_slice_new(QEMUIOVector);
>>> +            qemu_iovec_init(read_qiov, iov_cnt);
>>> +            qemu_iovec_concat_iov(read_qiov, iov, iov_cnt, 0, qiov.size);
>>
>> This is still wrong, how did you test it?
> 
> I sent it before reading the reviews from you and Kevin.  Bizarrely
> Windows saw the files I copied to the disk - even across reboot (no
> buffer cache involved?).  Or is Windows 8 doing tricks like "shutdown"
> is actually "suspend to disk"?

As far as I know this is exactly what it's doing. I've seen warnings
that you shouldn't mount file systems of a dual-boot Windows 8 if you
didn't change its options so that it really shuts down.

Kevin