Re: [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2)

[Hans de Goede]

Hi,

On 01/09/2013 09:52 PM, Blue Swirl wrote:

<snip>

> > diff --git a/hw/usb/quirks-ftdi-ids.h b/hw/usb/quirks-ftdi-ids.h
> > new file mode 100644
> > index 0000000..57c12ef
> > --- /dev/null
> > +++ b/hw/usb/quirks-ftdi-ids.h
> > @@ -0,0 +1,1255 @@
> > +/*
> > + * vendor/product IDs (VID/PID) of devices using FTDI USB serial converters.
> > + * Please keep numerically sorted within individual areas, thanks!
> > + *
> > + * Philipp Gühring - address@hidden - added the Device ID of the USB relais
> > + * from Rudolf Gugler
>
> License information is missing.
>
> Where is this file coming from, Linux?

Yes, it is a one on one copy of linux/drivers/usb/serial/ftdi_sio_ids.h,
so I did not think it would be a good idea to simply slap a copyright header on 
top
...

One could argue it is an integral part of linux/drivers/usb/serial/ftdi_sio.c 
and use
the copy right headers from there.

> Should we use linux-headers instead?

Since this is a copy of an internal kernel header, rather then of one from the
linux/include/linux or linux/include/asm "public" hierarchies it seemed wrong 
to me to
use linux-headers for this.

Regards,

Hans