Re: [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2)

[Blue Swirl]

On Wed, Jan 9, 2013 at 10:04 PM, Hans de Goede <address@hidden> wrote:
> Hi,
>
> On 01/09/2013 09:52 PM, Blue Swirl wrote:
>
> <snip>
>
>
>>> diff --git a/hw/usb/quirks-ftdi-ids.h b/hw/usb/quirks-ftdi-ids.h
>>> new file mode 100644
>>> index 0000000..57c12ef
>>> --- /dev/null
>>> +++ b/hw/usb/quirks-ftdi-ids.h
>>> @@ -0,0 +1,1255 @@
>>> +/*
>>> + * vendor/product IDs (VID/PID) of devices using FTDI USB serial
>>> converters.
>>> + * Please keep numerically sorted within individual areas, thanks!
>>> + *
>>> + * Philipp Gühring - address@hidden - added the Device ID of the USB
>>> relais
>>> + * from Rudolf Gugler
>>
>>
>> License information is missing.
>>
>> Where is this file coming from, Linux?
>
>
> Yes, it is a one on one copy of linux/drivers/usb/serial/ftdi_sio_ids.h,
> so I did not think it would be a good idea to simply slap a copyright header
> on top
> ...
>
> One could argue it is an integral part of
> linux/drivers/usb/serial/ftdi_sio.c and use
> the copy right headers from there.

That file uses GPLv2+ which would be nicer than the default GPLv2.
ftdi_sio_ids.h was extracted from ftdi_sio.h by
31844d55800e1b93fe75c4d6188a4a44db2e1bbe. ftdi_sio.h reaches beyond
git history but there were several contributors already during that
period.

Perhaps the license should be clarified with the Linux developers.

In this case the license is most probably either GPLv2 or GPLv2+ and
either is fine for QEMU use, but the lesson here is that committing
external files with no license information may be asking for trouble.

>
>
>> Should we use linux-headers instead?
>
>
> Since this is a copy of an internal kernel header, rather then of one from
> the
> linux/include/linux or linux/include/asm "public" hierarchies it seemed
> wrong to me to
> use linux-headers for this.

OK.

>
> Regards,
>
> Hans