[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-start |
Date: |
Mon, 12 Nov 2012 15:22:06 +0100 |
It works nicely with the QMP commands, but it adds useless complication
with HMP. In particular, see the following:
(qemu) nbd_server_add -w scsi0-hd0
(qemu) nbd_server_start -a localhost:10809
NBD server already exporting device scsi0-hd0
Signed-off-by: Paolo Bonzini <address@hidden>
---
blockdev-nbd.c | 5 +++++
1 file modificato, 5 inserzioni(+)
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index e362572..d1721a3 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -82,6 +82,11 @@ void qmp_nbd_server_add(const char *device, bool
has_writable, bool writable,
NBDExport *exp;
NBDCloseNotifier *n;
+ if (server_fd == -1) {
+ error_setg(errp, "NBD server not running");
+ return;
+ }
+
if (nbd_export_find(device)) {
error_setg(errp, "NBD server already exporting device '%s'", device);
return;
--
1.7.12.1
- [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 1/7] qemu-nbd: initialize main loop before block layer, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 2/7] nbd: accept relative path to Unix socket, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 3/7] nbd: accept URIs, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server was running, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 5/7] nbd: force read-only export for read-only devices, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-start,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 7/7] hmp: add NBD server commands, Paolo Bonzini, 2012/11/12
- Re: [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12, Paolo Bonzini, 2012/11/13