[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server w
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server was running |
Date: |
Mon, 12 Nov 2012 15:22:04 +0100 |
This failed on the new assertion of qemu_set_fd_handler2:
qemu-system-x86_64: /home/pbonzini/work/upstream/qemu/iohandler.c:60:
qemu_set_fd_handler2: Assertion `fd >= 0' failed.
Signed-off-by: Paolo Bonzini <address@hidden>
---
blockdev-nbd.c | 8 +++++---
1 file modificato, 5 inserzioni(+), 3 rimozioni(-)
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index 8031813..274fba6 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -113,7 +113,9 @@ void qmp_nbd_server_stop(Error **errp)
nbd_close_notifier(&cn->n, nbd_export_get_blockdev(cn->exp));
}
- qemu_set_fd_handler2(server_fd, NULL, NULL, NULL, NULL);
- close(server_fd);
- server_fd = -1;
+ if (server_fd != -1) {
+ qemu_set_fd_handler2(server_fd, NULL, NULL, NULL, NULL);
+ close(server_fd);
+ server_fd = -1;
+ }
}
--
1.7.12.1
- [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 1/7] qemu-nbd: initialize main loop before block layer, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 2/7] nbd: accept relative path to Unix socket, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 3/7] nbd: accept URIs, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server was running,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 5/7] nbd: force read-only export for read-only devices, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-start, Paolo Bonzini, 2012/11/12
- [Qemu-devel] [PATCH 7/7] hmp: add NBD server commands, Paolo Bonzini, 2012/11/12
- Re: [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12, Paolo Bonzini, 2012/11/13