Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

[Kashyap Chamarthy]

On Sat, Oct 13, 2012 at 2:01 AM, Eric Blake <address@hidden> wrote:
> On 10/12/2012 02:19 PM, Kashyap Chamarthy wrote:
>
>>
>> From eb4c4bc92c035c42c23c30c5e7ee73b54f9cf3a8 Mon Sep 17 00:00:00 2001
>> From: Kashyap Chamarthy <address@hidden>
>> Date: Sat, 13 Oct 2012 01:30:37 +0530
>> Subject: [PATCH] Add documentation for 'qemu-img info --backing-chain'
>>
>> Signed-off-by: Kashyap Chamarthy <address@hidden>
>> ---
>>  qemu-img.texi | 19 ++++++++++++++++++-
>>  1 file changed, 18 insertions(+), 1 deletion(-)
>
> We also need a patch to qemu-img-cmds.hx.
>
>> @@ -129,7 +133,7 @@ created as a copy on write image of the specified base 
>> image; the
>>  @var{backing_file} should have the same content as the input's base image,
>>  however the path, image format, etc may differ.
>>
>> address@hidden info [-f @var{fmt}] address@hidden @var{filename}
>> address@hidden info [-f @var{fmt}] address@hidden [--backing-chain] 
>> @var{filename}
>
> Introduced a spurious typo:
> s/ofamt/ofmt/
>
>>
>>  Give information about the disk image @var{filename}. Use it in
>>  particular to know the size reserved on disk which can be different
>> @@ -137,6 +141,19 @@ from the displayed size. If VM snapshots are stored in 
>> the disk image,
>>  they are displayed too. The command can output in the format @var{ofmt}
>>  which is either @code{human} or @code{json}.
>>
>> +If a disk image has a backing file chain, information about each disk image 
>> in
>> +the chain can be recursively enumerated by using the option 
>> @code{--backing-chain}
>
> Trailing whitespace.  Needs a '.' to end the sentence.

Thanks for the review Eric, new patch attached.

[PS: I haven't used 'git-send-email' for this trivial patch. Should I
have used that, instead of attaching it? I was wondering if
attachments like these are frowned upon. ]

/kashyap

>
> --
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

0001-Add-documentation-for-qemu-img-info-backing-chain-wi.patch
Description: Binary data