Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

[Kashyap Chamarthy]

On Sun, Oct 14, 2012 at 3:06 AM, Eric Blake <address@hidden> wrote:
> On 10/13/2012 09:50 AM, Kashyap Chamarthy wrote:
>
>>
>> [PS: I haven't used 'git-send-email' for this trivial patch. Should I
>> have used that, instead of attaching it? I was wondering if
>> attachments like these are frowned upon. ]
>
> That depends on who is applying the patch (it won't be me, since I'm not
> listed as maintainer); but even in my view as a reviewer, attachments
> embedded to a lengthy chain of reply text is harder to reply to than a
> fresh thread.  So, given that I have review comments below, you might as
> well use 'git send-email' to post a v2 as a fresh thread, so we don't
> have to worry about whether this will be spotted deeply embedded in a
> thread.

Noted.

>
>> From 68b22497ad1c9318ae57092f7e6af543b4106e1b Mon Sep 17 00:00:00 2001
>> From: Kashyap Chamarthy <address@hidden>
>> Date: Sat, 13 Oct 2012 20:54:28 +0530
>> Subject: [PATCH] Add documentation for 'qemu-img info --backing-chain' (with
>>  Eric's comments fixed)
>
> The subject line becomes part of the permanent git history, and as such,
> it should avoid versioning information, and just describe the change (or
> in other words, leave my name out of the 'git log --one-line' output).
> Better would be:
>
> qemu-img: document 'info --backing-chain'

Noted.

>
>>
>> Signed-off-by: Kashyap Chamarthy <address@hidden>
>> ---
>>  qemu-img-cmds.hx |  4 ++--
>>  qemu-img.texi    | 19 ++++++++++++++++++-
>>  2 files changed, 20 insertions(+), 3 deletions(-)
>>
>
>>
>> address@hidden --backing-chain
>> +will enumerate information about backing files in a disk image chain. Refer
>> +below for further description.
>> +
>>  @item size
>>  is the disk image size in bytes. Optional suffixes @code{k} or @code{K}
>>  (kilobyte, 1024) @code{M} (megabyte, 1024k) and @code{G} (gigabyte, 1024M)
>> @@ -129,7 +133,7 @@ created as a copy on write image of the specified base 
>> image; the
>>  @var{backing_file} should have the same content as the input's base image,
>>  however the path, image format, etc may differ.
>>
>> address@hidden info [-f @var{fmt}] address@hidden @var{filename}
>> address@hidden info [-f @var{fmt}] address@hidden [--backing-chain] 
>> @var{filename}
>
> Last time, you added a spurious 'a'; this time, you accidentally nuked
> an 'm'.  Please, leave @var{ofmt} untouched.

Sorry for the overlook, fixed and sent a new one as a fresh thread.

/kashyap

>
> --
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>