[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connec
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connect are portable |
Date: |
Thu, 4 Oct 2012 13:38:45 -0300 |
On Wed, 3 Oct 2012 16:36:50 +0200
Paolo Bonzini <address@hidden> wrote:
> They are just wrappers and do not need a Win32-specific version.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
> ---
> qemu-sockets.c | 49 +++++++++++++++++--------------------------------
> 1 file modificato, 17 inserzioni(+), 32 rimozioni(-)
>
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index 5cf2b32..79c7b66 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -731,6 +731,23 @@ int unix_connect_opts(QemuOpts *opts, Error **errp)
> return sock;
> }
>
> +#else
> +
> +int unix_listen_opts(QemuOpts *opts, Error **errp)
> +{
> + error_setg(errp, "unix sockets are not available on windows");
> + errno = ENOTSUP;
> + return -1;
> +}
> +
> +int unix_connect_opts(QemuOpts *opts, Error **errp)
> +{
> + error_setg(errp, "unix sockets are not available on windows");
> + errno = ENOTSUP;
> + return -1;
> +}
> +#endif
> +
> /* compatibility wrapper */
> int unix_listen(const char *str, char *ostr, int olen, Error **errp)
> {
> @@ -773,38 +790,6 @@ int unix_connect(const char *path, Error **errp)
> return sock;
> }
>
> -#else
> -
> -int unix_listen_opts(QemuOpts *opts, Error **errp)
> -{
> - error_setg(errp, "unix sockets are not available on windows");
> - errno = ENOTSUP;
> - return -1;
> -}
> -
> -int unix_connect_opts(QemuOpts *opts, Error **errp)
> -{
> - error_setg(errp, "unix sockets are not available on windows");
> - errno = ENOTSUP;
> - return -1;
> -}
> -
> -int unix_listen(const char *path, char *ostr, int olen, Error **errp)
> -{
> - error_setg(errp, "unix sockets are not available on windows");
> - errno = ENOTSUP;
> - return -1;
> -}
> -
> -int unix_connect(const char *path, Error **errp)
> -{
> - error_setg(errp, "unix sockets are not available on windows");
> - errno = ENOTSUP;
> - return -1;
> -}
> -
> -#endif
> -
> #ifdef _WIN32
> static void socket_cleanup(void)
> {
- Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno, (continued)
Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno, Markus Armbruster, 2012/10/17
[Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connect are portable, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 04/18] qemu-sockets: add nonblocking connect for Unix sockets, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 06/18] migration: centralize call to migrate_fd_error(), Paolo Bonzini, 2012/10/03