[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno |
Date: |
Thu, 4 Oct 2012 13:21:41 -0300 |
On Thu, 04 Oct 2012 18:16:13 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 04/10/2012 18:14, Luiz Capitulino ha scritto:
> >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
> >> > + const char *fmt, ...)
> >
> > The function's name makes me expect that something else is done with
> > os_errno
> ^^^^
>
> Why something "else"? :)
What I meant is that, it's not clear from the function's name how os_errno
is used. Actually, it gives the impression you're storing errno, but I might
be biased :)
But again, I don't have any better suggestions.
[Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connect are portable, Paolo Bonzini, 2012/10/03