[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option |
Date: |
Fri, 14 Sep 2012 08:20:42 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Peter Maydell <address@hidden> writes:
> On 12 September 2012 14:20, Laurent Desnogues
> <address@hidden> wrote:
>> Sorry, I had missed this patch...
>>
>> On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <address@hidden> wrote:
>>> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
>>> comma-separated target lists on the --target-list option. e.g.:
>>>
>>> $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>>> [...]
>>> ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>>> $
>>>
>>> This patch restores that ability.
>>>
>>> Signed-off-by: Eduardo Habkost <address@hidden>
>>> Cc: Daniel P. Berrange <address@hidden>
>>> Cc: Anthony Liguori <address@hidden>
>>> ---
>>> configure | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7656c32..9ee7038 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys;
>>> sys.exit(sys.version_info < (2,4) or sys.version_
>>> fi
>>>
>>> if test "$target_list" = "DEFAULT" ; then
>>> - target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>>> + target_list="$default_target_list"
>>> +else
>>> + target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>>> fi
>>
>> This works for me too.
>>
>> But I still can't get what the original patch posted by
>> Daniel Berrange intended to do:
>>
>> $ ./configure --target-list=
>> $ make V=1
>> cat | grep =y | sort -u > config-all-devices.mak
>>
>> And it of course hangs there.
>
> Hmm. Perhaps we should just revert 66d5499b3 and then recommit
> a working implementation later?
I think this is a good idea.
Regards,
Anthony Liguori
>
> -- PMM
- [Qemu-devel] [PATCH v2] Add ability to disable build of all targets, Daniel P. Berrange, 2012/09/10
- Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets, Anthony Liguori, 2012/09/10
- Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets, Eduardo Habkost, 2012/09/11
- [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option, Eduardo Habkost, 2012/09/11
- Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option, Peter Crosthwaite, 2012/09/11
- Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option, Laurent Desnogues, 2012/09/12
- Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option, Peter Maydell, 2012/09/14
- Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option,
Anthony Liguori <=
- Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option, Daniel P. Berrange, 2012/09/14
- Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option, Stefan Weil, 2012/09/14
- Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets, Laurent Desnogues, 2012/09/12